Skip to content

Conversation

@jishnub
Copy link
Member

@jishnub jishnub commented Jun 16, 2023

Since the following work,

julia> b = Block(1,2)
Block(1, 2)

julia> b + 1
Block(2, 3)

julia> b * 1
Block(1, 2)

it makes sense to define one and oneunit for Blocks, such that

julia> b + oneunit(b)
Block(2, 3)

julia> b * one(b)
Block(1, 2)

@codecov
Copy link

codecov bot commented Jun 16, 2023

Codecov Report

Merging #265 (acd9f9c) into master (e359943) will increase coverage by 0.14%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #265      +/-   ##
==========================================
+ Coverage   91.78%   91.92%   +0.14%     
==========================================
  Files          16       16              
  Lines        1461     1474      +13     
==========================================
+ Hits         1341     1355      +14     
+ Misses        120      119       -1     
Impacted Files Coverage Δ
src/BlockArrays.jl 66.66% <ø> (ø)
src/blockaxis.jl 96.26% <100.00%> (ø)
src/blockindices.jl 82.70% <100.00%> (+0.18%) ⬆️
src/blocklinalg.jl 94.57% <100.00%> (+0.73%) ⬆️
src/pseudo_blockarray.jl 86.84% <100.00%> (+0.11%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@dlfivefifty dlfivefifty merged commit ceaae29 into JuliaArrays:master Jun 20, 2023
@jishnub jishnub deleted the oneunit branch June 21, 2023 02:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants